{Synapse} Fix test fail in yum package #17661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
requested review from
aim-for-better,
idear1203 and
sunsw1994
as code owners
Juliehzl
approved these changes
Apr 13, 2021
Contributor
|
is *.ipynb required to test? |
Contributor
|
It doesn't quite make sense to me about this file extension renaming fix.
I think we should dig further and figure out the exact reason why the test case fails. CC: @zesluo who is going to be the owner of Synapse CLI. |
Member
Author
|
@fengzhou-msft Could you help take a look why it only fails in yum package? |
Member
Author
|
Closed since It fails infrequently. |
3 tasks
Member
Author
|
Resolved in #17704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test_notebookfails in Test Yum PackageIt might caused because the operation system ADO used can't deal with
ipynbfile. This PR changedipynbfile in test tojsonfile.Testing Guide
azdev test test_notebookThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.